-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sabre with streaming propfind #36336
Conversation
@@ -218,6 +218,7 @@ public function __construct(IRequest $request, $baseUri) { | |||
)); | |||
|
|||
if ($this->isRequestForSubtree(['files', 'trash-bin', 'public-files'])) { | |||
\Sabre\DAV\Server::$streamMultiStatus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed I think it would be safer to trigger this with a header to not disturb third party clients
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutly - this is just the simplification for the draft ...
Looks like the test suite cannot deal with streamed responses yet?
|
Same error after restarting drone .... looks like an issue we need to address in the code base ... @individual-it maybe you can throw an hour at this? THX a lot |
@individual-it is on leave for a while. Assigned myself so that I remember to allocate it to someone next week. |
Same error after restarting drone .... looks like an issue we need to address in the code base ... @individual-it maybe you can throw an hour at this? THX a lot
@phil-davis any idea already what's going on? Any pointers are welcome - THX |
c35fe4b
to
5f04383
Compare
Codecov Report
@@ Coverage Diff @@
## master #36336 +/- ##
============================================
- Coverage 65.16% 64.86% -0.31%
+ Complexity 19802 19775 -27
============================================
Files 1271 1271
Lines 74754 74707 -47
Branches 1309 1309
============================================
- Hits 48712 48456 -256
- Misses 25656 25865 +209
Partials 386 386
Continue to review full report at Codecov.
|
@DeepDiver1975 the issue seems to be a e.g. on master results in:
but in this branch it results into an invalid XML response:
|
even worse, PROPFIND on a non-existent user returns invalid XML, looks like we do not have enough tests for that case
should be
but is:
|
added extra test in #36435 |
@micbar this is only tagged |
@DeepDiver1975 What are the next steps here? |
I'm closing this - looks like this is no longer needed |
Description
sabre dav master branch introduced streaming support for propfind requests.
This PR introduced this for webdav v1 and all files endppoints on v2
This will reduce memory consumption on large folders and shall also increase responsiveness a bit.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: